Skip to content

Fix dxtbx.install_format for new setuptools / removed distutils#808

Merged
ndevenish merged 5 commits intomainfrom
dxtbx.install_format-use-pip
May 1, 2025
Merged

Fix dxtbx.install_format for new setuptools / removed distutils#808
ndevenish merged 5 commits intomainfrom
dxtbx.install_format-use-pip

Conversation

@dagewa
Copy link
Member

@dagewa dagewa commented Apr 30, 2025

It seems we do not test dxtbx.install_format, probably because it is difficult to do so.

@dagewa dagewa requested a review from ndevenish April 30, 2025 14:19
@ndevenish
Copy link
Collaborator

Probably want --user in here also, so it doesn't get written into the (possibly read-only) conda_base?

@ndevenish ndevenish merged commit 1d88582 into main May 1, 2025
10 checks passed
@ndevenish ndevenish deleted the dxtbx.install_format-use-pip branch May 1, 2025 15:02
ndevenish pushed a commit that referenced this pull request May 1, 2025
Using setup.py has been deprecated for a long time, and breaks in
newer setuptools versions.
ndevenish pushed a commit that referenced this pull request May 1, 2025
Using setup.py has been deprecated for a long time, and breaks in
newer setuptools versions.
@dagewa
Copy link
Member Author

dagewa commented May 22, 2025

Ah unfortunately this produces an error:

ERROR: --user is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with bzr+http, bzr+https, bzr+ssh, bzr+sftp, bzr+ftp, bzr+lp, bzr+file, git+http, git+https, git+ssh, git+git, git+file, hg+file, hg+http, hg+https, hg+ssh, hg+static-http, svn+ssh, svn+http, svn+https, svn+svn, svn+file).

aaronfinke pushed a commit to aaronfinke/dxtbx that referenced this pull request Oct 7, 2025
Using setup.py has been deprecated for a long time, and breaks in
newer setuptools versions.
aaronfinke pushed a commit to aaronfinke/dxtbx that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants