Move installation to toml based. #249
Merged
crangelsmith merged 7 commits intodevelopfrom Nov 8, 2023
Merged
Conversation
Merged
jolaem
approved these changes
Nov 7, 2023
| python3 -m venv env | ||
| source env/bin/activate | ||
| pip install -e . | ||
| python -m pip install -e . |
Collaborator
There was a problem hiding this comment.
Since the venv is running from python3 endpoint maybe update this to pyton3 too? or set both to python for consistency.
Collaborator
Author
There was a problem hiding this comment.
yes, good catch!
Collaborator
|
Testing both via |
settling to `python` instead of `python3`
adding `python -m pip install --upgrade pip` to instructions
marjanfamili
approved these changes
Nov 8, 2023
Collaborator
marjanfamili
left a comment
There was a problem hiding this comment.
All good for me. I installed and tested everything with python3 and on Mac M1.
Collaborator
Author
|
Merging this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue opened for a next PR in #250
To approve this PR it would be great if both @marjanfamili and @jolaem are able to run the installation, precommits and tests as described here: https://github.com/alan-turing-institute/affinity-vae/blob/e3c44807ac9a472844dbe94e0a319fd7ff5d5af2/README.md?plain=1#L27 and here https://github.com/alan-turing-institute/affinity-vae/blob/e3c44807ac9a472844dbe94e0a319fd7ff5d5af2/README.md?plain=1#L37
Run tests locally with:
https://github.com/alan-turing-institute/affinity-vae/blob/e842398dd94e8977c602a7b05389e2e391d38fae/.github/workflows/tests.yml#L18