Skip to content

Comments

Pydantic config#251

Merged
crangelsmith merged 22 commits intodevelopfrom
201-pydantic-config
Nov 16, 2023
Merged

Pydantic config#251
crangelsmith merged 22 commits intodevelopfrom
201-pydantic-config

Conversation

@crangelsmith
Copy link
Collaborator

@crangelsmith crangelsmith commented Nov 3, 2023

Fixes #201

  • Uses pydantic for input validation
  • Moves global variables from config.py to settings.py, leaving config.py for implementation of the point above.
  • Added and updated tests.
  • Updates in many files for the change of config.VIS_X to settings.VIS_X (X) here is a placeholder.
  • Updated config.yml example file to be used in tests.

@crangelsmith crangelsmith changed the base branch from develop to 238-toml-tests November 3, 2023 15:56
@crangelsmith crangelsmith changed the base branch from 238-toml-tests to develop November 8, 2023 15:07
@crangelsmith crangelsmith marked this pull request as ready for review November 8, 2023 17:16
Copy link
Collaborator

@jolaem jolaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks Camilla!

Copy link
Collaborator

@marjanfamili marjanfamili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@marjanfamili
Copy link
Collaborator

marjanfamili commented Nov 16, 2023

Missing from Readme for conda installation

conda install -c conda-forge tensorboard
conda install -c conda-forge matplotlib

pip install pyyaml

adding missing libraries for baskerville conda installation
@crangelsmith
Copy link
Collaborator Author

Merging as its been tested locally and Baskerville.

@crangelsmith crangelsmith merged commit 98fce5a into develop Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using pydantic for configuration

3 participants