Splitting module use commands onto separate lines
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Collaborator
|
I agree this shouldn't introduce any issues. @cconroy20 I suggest merging |
Interesting. I'm guessing the issue is the dynamic dependency scanner around https://github.com/mesonbuild/meson/blob/e6122ba7864cf7b4c20091651e69d33ba2f7b463/mesonbuild/scripts/depscan.py#L67-L79? |
Contributor
Author
|
@eli-schwartz — Yeah that's what I tracked it down to. I'll open an issue with a simple example on meson at some point! |
Owner
|
done
… On Sep 5, 2022, at 7:41 PM, Ben Johnson ***@***.***> wrote:
I agree this shouldn't introduce any issues. @cconroy20 <https://github.com/cconroy20> I suggest merging
—
Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYRA6SQJCFOKOJ5FWKUSETV42AMFANCNFSM6AAAAAAQFJ747I>.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on dfm/python-fsps#186, I discovered that the meson build system that we're trying to use for the Python bindings doesn't support multiple module includes per line. That's really a bug in meson, but the easiest fix is probably to just split the
usecommands here. I don't think this should introduce any issues - any thoughts?