Fix: DO-3494: Strip Table column prefix when filtering and sorting #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Due to the fact that Table column conversion happens as the last step, all filtering and sorting queries would try to operate on the raw data using the internal column names.
Implementation Description
Rather than changing the API and forcing all transformations to happen on the converted data, the prefix is stripped altogether. The only downside is potentially in the future when we add automatic column filters: when trying to filter/sort non-unique column names - in that case the filtering would apply to all matching column names instead of the requested column. Right now it is not possible to specify column filters for duplicate column names anyway.
Any new dependencies Introduced
How Has This Been Tested?
Added a pagination ordering test, added more testcases for filtering.
PR Checklist:
Screenshots (if appropriate):