Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: DO-3494: Make Table schema cache_key a query param #354

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Fix: DO-3494: Make Table schema cache_key a query param #354

merged 7 commits into from
Aug 5, 2024

Conversation

Roman-Kornev
Copy link
Contributor

@Roman-Kornev Roman-Kornev commented Aug 5, 2024 •
edited
Loading

Motivation and Context

The param was being sent as a body which is not allowed for a GET request.

Implementation Description

Any new dependencies Introduced

How Has This Been Tested?

PR Checklist:

  • I have implemented all requirements? (see JIRA, project documentation).
  • I am not affecting someone else's work, If I am, they are included as a reviewer.
  • I have added relevant tests (unit, integration or regression).
  • I have added comments to all the bits that are hard to follow.
  • I have added/updated Documentation.
  • I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

@Roman-Kornev Roman-Kornev self-assigned this Aug 5, 2024
@Roman-Kornev Roman-Kornev merged commit 670eaf1 into master Aug 5, 2024
2 checks passed
@Roman-Kornev Roman-Kornev deleted the table-qs branch August 5, 2024 15:18
Roman-Kornev added a commit that referenced this pull request Aug 6, 2024
@Roman-Kornev
Merge remote-tracking branch 'origin/master' into table-qs
eddfa17 
* origin/master:
  Version bump to v1.12.2 [skip ci]
  Fix: DO-3494: Make Table schema cache_key a query param (#354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztof-causalens krzysztof-causalens krzysztof-causalens approved these changes

@patricia-causalens patricia-causalens Awaiting requested review from patricia-causalens

Assignees

@Roman-Kornev Roman-Kornev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roman-Kornev @krzysztof-causalens