Skip to content

switch transaction_gas_test tests to TraitsTest #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+116 −92
Open

switch transaction_gas_test tests to TraitsTest #1822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 116 additions & 92 deletions category/execution/ethereum/transaction_gas_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <category/execution/ethereum/core/transaction.hpp>
#include <category/execution/ethereum/transaction_gas.hpp>
#include <category/vm/evm/traits.hpp>
#include <monad/test/traits_test.hpp>

#include <evmc/evmc.h>
#include <evmc/evmc.hpp>
Expand All @@ -28,143 +29,166 @@

using namespace monad;

TEST(TransactionGas, intrinsic_gas)
namespace
{
// Frontier
{
Transaction t{};
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_FRONTIER>>(t), 21'000);
template <evmc_revision r>
using rev = std::integral_constant<evmc_revision, r>;
}

t.data.push_back(0x00);
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_FRONTIER>>(t), 21'004);
TYPED_TEST(TraitsTest, intrinsic_gas)
{
auto non_zero_since = []<evmc_revision r>(rev<r>, uint64_t val) consteval {
if constexpr (TestFixture::Trait::evm_rev() >= r) {
return val;
}
else {
return 0;
}
};

t.data.push_back(0xff);
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_FRONTIER>>(t), 21'072);
}
static constexpr auto empty_to =
non_zero_since(rev<EVMC_HOMESTEAD>{}, 32'000);

// Homestead
{
Transaction t{};
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_HOMESTEAD>>(t), 53'000);
EXPECT_EQ(
intrinsic_gas<typename TestFixture::Trait>(t), 21'000 + empty_to);
}

{
Transaction t{};
t.to = 0xf8636377b7a998b51a3cf2bd711b870b3ab0ad56_address;
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_HOMESTEAD>>(t), 21'000);
EXPECT_EQ(intrinsic_gas<typename TestFixture::Trait>(t), 21'000);
}

// Spurious Dragon
static constexpr auto zero_token_cost = 4;
static constexpr auto non_zero_token_cost = [] {
if constexpr (TestFixture::Trait::evm_rev() < EVMC_ISTANBUL) {
// EIP-2028
return 68;
}
else {
return 16;
}
}();

// EIP-3860
// only charged when tx.to is not set
static constexpr auto extra_cost_per_evm_word =
non_zero_since(rev<EVMC_SHANGHAI>{}, 2);

{
Transaction t{};
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_SPURIOUS_DRAGON>>(t), 53'000);

t.to = 0xf8636377b7a998b51a3cf2bd711b870b3ab0ad56_address;
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_SPURIOUS_DRAGON>>(t), 21'000);
t.data.push_back(0x00);
EXPECT_EQ(
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + empty_to + zero_token_cost + extra_cost_per_evm_word);

t.data.push_back(0xff);
EXPECT_EQ(
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + empty_to + zero_token_cost + non_zero_token_cost +
extra_cost_per_evm_word);
}

// Byzantium
{
Transaction t{};
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_BYZANTIUM>>(t), 53'000);
byte_string data;
for (auto i = 0; i < 127; ++i) {
data.push_back(0xc0);
}
data.push_back(0x00);

t.to = 0xf8636377b7a998b51a3cf2bd711b870b3ab0ad56_address;
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_BYZANTIUM>>(t), 21'000);
Transaction const t{.data = data};

EXPECT_EQ(
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + empty_to + non_zero_token_cost * 127 + zero_token_cost +
4 * extra_cost_per_evm_word);
}

// Istanbul
{
Transaction t{};
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_ISTANBUL>>(t), 53'000);

t.to = 0xf8636377b7a998b51a3cf2bd711b870b3ab0ad56_address;

t.data.push_back(0x00);
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_ISTANBUL>>(t), 21'004);
EXPECT_EQ(
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + zero_token_cost);

t.data.push_back(0xff);
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_ISTANBUL>>(t), 21'020);
EXPECT_EQ(
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + zero_token_cost + non_zero_token_cost);
}

// Berlin
// EIP-2930
static constexpr auto cost_per_access_list_address =
non_zero_since(rev<EVMC_BERLIN>{}, 2'400);
static constexpr auto cost_per_access_list_key =
non_zero_since(rev<EVMC_BERLIN>{}, 1'900);

{
Transaction t{};
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_BERLIN>>(t), 53'000);

t.to = 0xf8636377b7a998b51a3cf2bd711b870b3ab0ad56_address;
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_BERLIN>>(t), 21'000);

static constexpr auto key1{
0x0000000000000000000000000000000000000000000000000000000000000007_bytes32};
static constexpr auto key2{
0x0000000000000000000000000000000000000000000000000000000000000003_bytes32};
t.access_list.push_back({*t.to, {key1, key2}});
EXPECT_EQ(
intrinsic_gas<EvmTraits<EVMC_BERLIN>>(t),
21'000 + 2400 + 1900 + 1900);
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + cost_per_access_list_address +
2 * cost_per_access_list_key);

t.data.push_back(0x00);
t.data.push_back(0xff);
EXPECT_EQ(intrinsic_gas<EvmTraits<EVMC_BERLIN>>(t), 27'220);
}

// Shanghai EIP-3860
{
byte_string data;
for (auto i = 0u; i < uint64_t{0x80}; ++i) {
data += {0xc0};
}

Transaction const t{.data = data};

EXPECT_EQ(
intrinsic_gas<EvmTraits<EVMC_SHANGHAI>>(t),
32'000u + 21'000u + 16u * 128u + 0u + 4u * 2u);
intrinsic_gas<typename TestFixture::Trait>(t),
21'000 + cost_per_access_list_address +
2 * cost_per_access_list_key + zero_token_cost +
non_zero_token_cost);
}
}

TEST(TransactionGas, txn_award)
TYPED_TEST(TraitsTest, txn_award)
{
// Frontier
{
// gas price
EXPECT_EQ(
gas_price<EvmTraits<EVMC_FRONTIER>>(
Transaction{.max_fee_per_gas = 1'000}, 0u),
1'000);

// txn award
EXPECT_EQ(
calculate_txn_award<EvmTraits<EVMC_FRONTIER>>(
Transaction{.max_fee_per_gas = 100'000'000'000}, 0, 90'000'000),
uint256_t{9'000'000'000'000'000'000});
// gas price
Transaction const t0{.max_fee_per_gas = 1'000};
Transaction const t1{
.max_fee_per_gas = 3'000,
.type = TransactionType::legacy,
.max_priority_fee_per_gas = 1'000};
Transaction const t2{
.max_fee_per_gas = 3'000, .type = TransactionType::legacy};
Transaction const t3{
.max_fee_per_gas = 5'000,
.type = TransactionType::eip1559,
.max_priority_fee_per_gas = 1'000};
Transaction const t4{
.max_fee_per_gas = 5'000, .type = TransactionType::eip1559};
Transaction const t5{
.max_fee_per_gas = 5'000,
.type = TransactionType::eip1559,
.max_priority_fee_per_gas = 4'000};

EXPECT_EQ(gas_price<typename TestFixture::Trait>(t0, 0u), 1'000);
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t1, 2'000u), 3'000);
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t2, 2'000u), 3'000);
if constexpr (TestFixture::Trait::evm_rev() < EVMC_LONDON) {
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t3, 2'000u), 5'000);
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t4, 2'000u), 5'000);
}

// London
{
// gas price
Transaction const t1{
.max_fee_per_gas = 3'000,
.type = TransactionType::legacy,
.max_priority_fee_per_gas = 1'000};
Transaction const t2{
.max_fee_per_gas = 3'000, .type = TransactionType::legacy};
Transaction const t3{
.max_fee_per_gas = 5'000,
.type = TransactionType::eip1559,
.max_priority_fee_per_gas = 1'000};
Transaction const t4{
.max_fee_per_gas = 5'000, .type = TransactionType::eip1559};
Transaction const t5{
.max_fee_per_gas = 5'000,
.type = TransactionType::eip1559,
.max_priority_fee_per_gas = 4'000};
EXPECT_EQ(gas_price<EvmTraits<EVMC_LONDON>>(t1, 2'000u), 3'000);
EXPECT_EQ(gas_price<EvmTraits<EVMC_LONDON>>(t2, 2'000u), 3'000);
EXPECT_EQ(gas_price<EvmTraits<EVMC_LONDON>>(t3, 2'000u), 3'000);
EXPECT_EQ(gas_price<EvmTraits<EVMC_LONDON>>(t4, 2'000u), 2'000);
EXPECT_EQ(gas_price<EvmTraits<EVMC_LONDON>>(t5, 2'000u), 5'000);

// txn award
EXPECT_EQ(
calculate_txn_award<EvmTraits<EVMC_LONDON>>(
Transaction{.max_fee_per_gas = 100'000'000'000}, 0, 90'000'000),
uint256_t{9'000'000'000'000'000'000});
else {
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t3, 2'000u), 3'000);
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t4, 2'000u), 2'000);
}
EXPECT_EQ(gas_price<typename TestFixture::Trait>(t5, 2'000u), 5'000);

// txn award
EXPECT_EQ(
calculate_txn_award<typename TestFixture::Trait>(
Transaction{.max_fee_per_gas = 100'000'000'000}, 0, 90'000'000),
uint256_t{9'000'000'000'000'000'000});
}
Loading