switch transaction_gas_test tests to TraitsTest #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the transaction gas tests to use the parameterized TraitsTest fixture instead of hard-coded EVM revision tests. This enables testing across all EVM revisions systematically while adapting expectations based on revision-specific features (EIP-2028, EIP-2930, EIP-3860, and EIP-1559).
Key changes:
- Replaced separate TEST functions with TYPED_TEST using TraitsTest fixture
- Introduced helper functions to compute revision-dependent gas costs at compile-time
- Consolidated previously separated revision-specific test cases into unified parameterized tests
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
goodlyrottenapple
force-pushed
the
sam/traits_test_transaction_gas_test
branch
from
2fae3ef to
3aeb3fe
Compare
goodlyrottenapple
force-pushed
the
sam/traits_test_transaction_gas_test
branch
from
3aeb3fe to
7be3545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.