Deploy to production #1638
Merged
Deploy to production #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cleaner way of doing the for loop push thing. See #1625 (comment)
GA loads async, so this was never completing and thus never firing. Also, I'm removing the IP address. We don't need it and it's uncomfortable.
Co-authored-by: Anthony Ricaud <anthony@ricaud.me>
fix(rate-limit): suggestion from @rik
fix(ga): wait until ga has loaded before firing
Listen. I hated doing this. I truly did in every way that I can imagine, but our deployment strategy isn't built considering things like using composer or another package management system. So, here we are, checking in our deps. We'll do this until we come up with a different deployment strategy. I've got some ideas but it'll take a bit. Maybe in the new year.
chore(deps): moving dependencies to git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.