fix(rate-limit): check runs, not tests #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current code, somebody could potentially run 900 test runs (well, more since the cache is in-memory) before they hit the limit. Let's count every run.
tkadlec
approved these changes
Nov 15, 2021
rik
reviewed
Nov 15, 2021
Comment on lines
+20
to
+22
| for ($i = 0; $i < $times_to_add; $i++) { | ||
| $bucket[] = time(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| for ($i = 0; $i < $times_to_add; $i++) { | |
| $bucket[] = time(); | |
| } | |
| array_push($bucket, ...array_fill(0, $times_to_add, time())); |
Contributor
Author
There was a problem hiding this comment.
Oh that's a lot nicer!
jefflembeck
added a commit
that referenced
this pull request
Nov 15, 2021
This is a cleaner way of doing the for loop push thing. See #1625 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code, somebody could potentially run 900 test runs (well,
more since the cache is in-memory) before they hit the limit. Let's
count every run.