small cleanup to error messages in general while focusing on #1601. #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottjehl
requested review from
jefflembeck,
pmeenan and
tkadlec
and removed request for
pmeenan
jefflembeck
reviewed
Oct 28, 2021
www/runtest.php
Outdated
| $passesMonthly = $cmrl->check(); | ||
|
|
||
| if(!$passesMonthly) { | ||
| $error = '<p><strong>You\'ve hit the max on anonymous tests this month, but don\'t worry! You can keep testing...</strong> You\'ll just need to <a href="/saml/login.php">log in</a>, which gives you access to other nice features like saved test history and no hourly rate limits as well.</p>' . loggedOutLoginForm(); |
Contributor
There was a problem hiding this comment.
Yes! ❤️ the friendly and helpful tone here.
jefflembeck
reviewed
Oct 28, 2021
tkadlec
approved these changes
Oct 29, 2021
Contributor
tkadlec
left a comment
tkadlec
left a comment
There was a problem hiding this comment.
This is looking in great shape! 
(one day I will find out why that is the ship it icon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1601. This is set up to ideally allow populating $error with strings or HTML in cases where the error is going only to the web and not api/json.