Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deconstructing stairs creates "nothing" #6141

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Feb 28, 2025

Purpose of change (The Why)

Close #5991

Describe the solution (The How)

Change t_null into t_open_air for its terrain setting in deconstruction.

Describe alternatives you've considered

None.

Testing

  1. Teleport to location with wooden stairs.
  2. Deconstruct them.
  3. Teleport floor above around stairs.
  4. You should see open air instead of void in reality.

Additional context

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 28, 2025
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/13586048297/job/37981170421?pr=6141

 (~[slow] ~[.],starting_items)=> (continued from above) ERROR: t_wood_stairs_down deconstructs into "t_open_air", but "t_null" is preferred

looks like for some reason stairs are meant to deconstruct into t_null; code changes are necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deconstructing stairs creates "nothing"
2 participants