Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): add craftable underbarrel laser sight #6030

Merged

Conversation

Goredell
Copy link
Contributor

@Goredell Goredell commented Feb 1, 2025

Purpose of change (The Why)

While we are able crafting multiple quite advanced energo weapons and cbms , yet we are unable to craft relatively simple gunmod.

Describe the solution (The How)

Add cfafting recipe

Testing

Game builds and starts, craft works as intended

Additional context

Balance suggestions are welcome

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 1, 2025
Copy link
Contributor

autofix-ci bot commented Feb 1, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Goredell Goredell marked this pull request as draft February 1, 2025 12:59
@Goredell Goredell force-pushed the craftable-underbarrel-laser branch from e221d3e to 4583716 Compare February 1, 2025 13:37
@Goredell Goredell marked this pull request as ready for review February 1, 2025 13:41
Copy link
Collaborator

@yay855 yay855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest also adding in an uncraft for laser sights, or even just making the recipe reversible. Other than that, I'll want to get the okay from at least one other dev before I approve this, but it looks good to me.

RoyalFox2140
RoyalFox2140 previously approved these changes Feb 1, 2025
@RoyalFox2140 RoyalFox2140 merged commit 62e1cd3 into cataclysmbnteam:main Feb 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants