refactor: fix compiler warnings

src/character.cpp

@@ -613,10 +613,10 @@
 }
 
 Character::Character( Character &&source )  noexcept : Creature( std::move( source ) ),
     worn( new worn_item_location( this ) ),
     inv( new character_item_location( this ) )
 {
     move_operator_common( std::move( source ) );
 }
 
 Character &Character::operator=( Character &&source )
@@ -624,7 +624,7 @@
 {
     move_operator_common( std::move( source ) );
 
     Creature::operator=( std::move( source ) );
     return *this;
 }
 
@@ -8764,7 +8764,6 @@
     bool in_skater_vehicle = in_vehicle && veh_part.part_with_feature( "SEAT_REQUIRES_BALANCE", false );
 
     if( ( worn_with_flag( flag_REQUIRES_BALANCE ) || in_skater_vehicle ) && !is_on_ground() ) {
-        int rolls = 4;
         if( worn_with_flag( flag_ROLLER_ONE ) && !in_skater_vehicle ) {
             if( worn_with_flag( flag_REQUIRES_BALANCE ) && !has_effect( effect_downed ) ) {
                 int rolls = 4;

src/game.cpp

@@ -930,7 +930,7 @@
     // Add a timestamp for uniqueness.
     char buffer[suffix_len] {};
     std::time_t t = std::time( nullptr );
     std::strftime( buffer, suffix_len, "%Y-%m-%d-%H-%M-%S", std::localtime( &t ) );
     memorial_file_path << buffer;
 
     return memorial_file_path.str();
@@ -4318,7 +4318,7 @@
                     targ->apply_damage( source, bodypart_id( "torso" ), dam_mult * force_remaining );
                     targ->check_dead_state();
                 }
                 m.bash( traj[i], 2 * dam_mult * force_remaining );
                 break;
             } else if( critter_at( traj[i] ) ) {
                 targ->setpos( traj[i - 1] );
@@ -4398,7 +4398,7 @@
                     }
                     targ->check_dead_state();
                 }
                 m.bash( traj[i], 2 * dam_mult * force_remaining );
                 break;
             } else if( critter_at( traj[i] ) ) {
                 targ->setpos( traj[i - 1] );
@@ -4481,7 +4481,7 @@
                     }
                     u.check_dead_state();
                 }
                 m.bash( traj[i], 2 * dam_mult * force_remaining );
                 break;
             } else if( critter_at( traj[i] ) ) {
                 u.setpos( traj[i - 1] );
@@ -8534,13 +8534,13 @@
                 disassembly_stacks_res.emplace_back( stack.first->typeId(), stack.second );
             }
 
-            for( int i = 0; i < disassembly_stacks_res.size(); i++ ) {
+            for( int i = 0; i < static_cast<int>( disassembly_stacks_res.size() ); i++ ) {
                 const auto dis = recipe_dictionary::get_uncraft( disassembly_stacks_res[i].first );
                 time_to_disassemble_rec += dis.time * disassembly_stacks_res[i].second;
                 //uses default craft materials to estimate recursive disassembly time
                 const auto components = dis.disassembly_requirements().get_components();
                 for( const auto &subcomps : components ) {
                     if( subcomps.size() > 0 ) {
                         disassembly_stacks_res.emplace_back( subcomps.front().type,
                                                              subcomps.front().count * disassembly_stacks_res[i].second );
                     }
@@ -11459,7 +11459,7 @@
 void game::autosave()
 {
     //Don't autosave if the min-autosave interval has not passed since the last autosave/quicksave.
     if( time( nullptr ) < last_save_timestamp + 60 * get_option<int>( "AUTOSAVE_MINUTES" ) ) {
         return;
     }
     quicksave();    //Driving checks are handled by quicksave()

src/recipe.cpp

@@ -602,7 +602,7 @@ std::function<bool( const item & )> recipe::get_component_filter(
     };
 }
 
-static std::string dump_requirements(
+[[maybe_unused]] static std::string dump_requirements(
     const requirement_data &reqs,
     int move_cost,
     const std::map<skill_id, int> &skills )

src/vehicle_move.cpp

@@ -656,13 +656,6 @@ veh_collision vehicle::part_collision( int part, const tripoint &p,
     // 0.001 -> 1 meter. Left modifiable so that armor or other parts can affect it.
     float deformation_distance = density_factor / 100;
 
-    //Calculates mass factor. Depreciated, maintained for stats.
-    // factor = -25 if mass is much greater than mass2
-    // factor = +25 if mass2 is much greater than mass
-    const float weight_factor = mass >= mass2 ?
-                                -25 * ( std::log( mass ) - std::log( mass2 ) ) / std::log( mass ) :
-                                25 * ( std::log( mass2 ) - std::log( mass ) ) / std::log( mass2 );
-
     bool smashed = true;
     const std::string snd = _( "smash!" );
     float part_dmg = 0;