Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Wild Veggy, Mushroom Buff #5608

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

yay855
Copy link
Collaborator

@yay855 yay855 commented Oct 24, 2024

Increased the calorie count of mushrooms from 24 to 50 and wild veggies from 34 to 50; increased specific calorie-overriding recipes' calorie count to compensate. Also increased the number of mushrooms and wild veggies you can forage at once.

Checklist

Required

Optional

Purpose of change

Wild veggies and mushrooms were fairly useless beforehand thanks to their exceptionally low calorie count; they weren't worth farming, and they were barely worth foraging.

Describe the solution

Mushrooms and wild veggies have had their calorie count nearly doubled and their forage amount increased slightly, making them a better choice for foraging and farming players.

Describe alternatives you've considered

Rebalance every single fruit and veggie out there to make them all worthwhile to eat, even if some are still worth more calories.

Testing

Additional context

Increased the calorie count of mushrooms from 24 to 50 and wild veggies from 34 to 50; increased specific calorie-overriding recipes' calorie count to compensate. Also increased the number of mushrooms and wild veggies you can forage at once.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 24, 2024
@yay855
Copy link
Collaborator Author

yay855 commented Oct 24, 2024

Mother_lover,_ the calorie test is based on mushroom soup.

@chaosvolt
Copy link
Member

Comestibles test are most likely failing because recipes are calling for amounts of the mushroom_soup_ingredients crafting requirement now providing twice the calories they were earlier.

@yay855
Copy link
Collaborator Author

yay855 commented Oct 25, 2024

Comestibles test are most likely failing because recipes are calling for amounts of the mushroom_soup_ingredients crafting requirement now providing twice the calories they were earlier.

Yeah, I figured. The question is, what can I do about it?

@chaosvolt
Copy link
Member

Yeah, I figured. The question is, what can I do about it?

  {
    "id": "mushroom_soup_ingredients",
    "type": "requirement",
    "components": [
      [ [ "broth", 1 ] ],
      [ [ "mushroom", 1 ], [ "mushroom_cooked", 1 ], [ "dry_mushroom", 1 ], [ "morel_cooked", 1 ] ],
      [ [ "flour", 1 ] ]
    ]
  },

These already call for only one each of the ingredient, so my initial assumed solution of cut how many mushrooms are called for by this recipe in half won't work. I'd say start by trying this:

  1. Increase the required broth and flour in that crafting quality from 1 to 2, leaving the mushrooms untouched.
  2. Cut the amounts of this quality in all recipes that use it in half.

Hopefully then tests will pass, if not then will have to see what else is being fucky.

@RoyalFox2140
Copy link
Collaborator

Calorie changes are fine to me, feel free to merge when tests pass.

@chaosvolt
Copy link
Member

Tests are already failed and still need fixing. If they don't tackle it by the time I get home I'll do it.

@chaosvolt
Copy link
Member

So I just realized that the broth and flour is not alternatives but part of a component set actually, will fix the item calories in a sec.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4744

@chaosvolt chaosvolt merged commit dba7a53 into cataclysmbnteam:main Oct 25, 2024
9 checks passed
@yay855 yay855 deleted the wild-veggie-buff branch October 25, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants