Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump android ndk to 26 #5540

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 8, 2024

Checklist

Required

Optional

  • This is a PR that modifies build process or code organization.

(skipping docs step because it's a only a version bump)

Purpose of change

support C++20 features fully and prevent this from happening

Describe the solution

bump NDK to 26

required for C++20 libc++ support to work properly: https://github.com/android/ndk/releases/tag/r26
this update disables kitkat support
@scarf005 scarf005 mentioned this pull request Oct 8, 2024
4 tasks
@scarf005 scarf005 enabled auto-merge (squash) October 8, 2024 17:51
Copy link
Collaborator

@OrenAudeles OrenAudeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple version bump, necessary for concepts and requires PRs going forward.

@scarf005 scarf005 merged commit 5450403 into cataclysmbnteam:main Oct 8, 2024
7 checks passed
@scarf005 scarf005 deleted the build/bump-ndk branch October 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants