Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct stack_size of hickory nut ambrosia to make sense with recipe requirements #5146

Merged

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

This fixes hickory nut ambrosia being about 4 times as dense as it's expected to be. A quick glance at the recipe showed that the issue was that charges divides its volume into 4.

The expected fix WOULD be to just divide weight by 4, but...it takes 10 charges of water in addition to nuts, sweetener,and milk while outputting 10 charges, so the ACTUAL answer is it clearly needs a stack size defined, derp.

Fixes #5114

Describe the solution

Added stack_size value of 1 to hickory nut ambrosia.

Describe alternatives you've considered

  1. Screaming because I was this fucking close to going the "divide weight by 4" before I thought to actually check what the recipe implies.
  2. Making the recipe less watered down. I dunno what the intended proportions are for this blursed nut pilk, since this is a drink I've never actually heard of before IRL to be honest.
  3. Adding posca instead because that is a blursed drink I HAVE heard of IRL.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Examined recipe, it showed that it makes 2.5 liters of ambrosia per batch now, while weight remains unchanged.

image

Additional context

@github-actions github-actions bot added the data label Aug 4, 2024
@chaosvolt chaosvolt merged commit 071a8f9 into cataclysmbnteam:main Aug 4, 2024
9 of 10 checks passed
@chaosvolt chaosvolt deleted the it-is-i-who-hickory-nuts-to-that branch August 4, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hickory nut Ambrosia is impossibly dense
2 participants