Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: PR title generator & update contributing guideline #4812

Merged
merged 8 commits into from
Jun 16, 2024

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Jun 16, 2024

Purpose of change

make opening PR (and following requirements) easier for beginners.

Describe the solution

  • auto-update semantic.yml (and allowed mod list)
  • made checklist more prominent
  • added pr title generator in docs page

Describe alternatives you've considered

using UI framework like preact over raw dom manipulation, but the component was simple enough.

Testing

Additional context

2024-06-16_20-28-26.mp4

Checklist

  • I wrote the PR title in conventional commit format, see above
  • I ran the code formatter
  • I linked any relevant issues using github keyword syntax

@github-actions github-actions bot added docs PRs releated to docs page scripts related to game management scripts labels Jun 16, 2024
@scarf005 scarf005 merged commit fdc09d8 into cataclysmbnteam:main Jun 16, 2024
10 checks passed
@scarf005 scarf005 deleted the docs/pr-title-gen branch June 16, 2024 22:55
@chaosvolt
Copy link
Member

* made checklist more prominent

Shit, I didn't see this and also didn't realize it meant bringing back the checklist spam that was removed in #3677 specifically because it's a nuisance for 90% of PRs, or I wouldn't have approved this.

@scarf005
Copy link
Member Author

it does say to remove unrelated sections, tho

@chaosvolt
Copy link
Member

Yes but that's a pointless annoyance to clutter every single PR with when 90% of it just gets removed.

@chaosvolt
Copy link
Member

Eh, for now we can leave it be, see if it helps anyone and just comment it out if others complain I guess.

@scarf005 scarf005 restored the docs/pr-title-gen branch December 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page scripts related to game management scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants