Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release daily #3595

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Nov 8, 2023

Summary

SUMMARY: Build "Only release daily"

Purpose of change

we have too much releases, 99% are unused and makes navigating painful

Describe the solution

release daily iff there were commits yesterday.

Describe alternatives you've considered

maybe set cron to run 23:00?

Testing

will run on fork.

Additional context

  • also gotta remove old releases with multiple release per day

@olanti-p
Copy link
Contributor

olanti-p commented Nov 8, 2023

Another issue of having multiple releases per day, is that people frequently discard the build time part when they speak about build number, which introduces extra confusion.

@scarf005 scarf005 requested a review from olanti-p November 8, 2023 20:32
@scarf005 scarf005 force-pushed the ci-daily-release branch 2 times, most recently from 37757c5 to 0142f64 Compare November 13, 2023 03:24
only releases if there's commits to publish.
@scarf005
Copy link
Member Author

image
image

ran locally, works now. was previously failing due to using GITHUB_ENV(shared per steps) over GITHUB_OUTPUT(shared per jobs)

https://github.com/scarf005/Cataclysm-BN/actions/runs/6845387412

Copy link
Contributor

@olanti-p olanti-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's see how it works out

@olanti-p olanti-p added this pull request to the merge queue Nov 13, 2023
Merged via the queue into cataclysmbnteam:upload with commit 2b4f485 Nov 13, 2023
11 of 13 checks passed
@scarf005 scarf005 deleted the ci-daily-release branch November 13, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants