Fix 20ga percussion ammo inheritance and names #3195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix up abstract used by 20 gauge percussion shells so they don't drop shotgun hulls, standardize naming convention"
Purpose of change
It was pointed out that the cap-and-ball shotshells were leaving behind regular plastic shotshells as casings due to the ammo inheriting from regular 12 gauge shot, when it turns out that trying to delete a
casing
entry inherited from something else doesn't quite work right.Along the way it was also found that the ammo has its own abstract entry but it inherits from the regular shot abstract, and moreover was actually only used by the slug variant. And finally, the names were all over the place in a way that made them confusing, easily mistaken for the flintlock cartridges for one.
Describe the solution
Describe alternatives you've considered
Screaming.
Testing
Additional context
This doesn't matter much right now since the lemat's secondary is the only thing that uses it, but @hirohito1 has plans to add a percussion-cap shotgun that will also use it, on the basis that percussion muzzleloaders are way more common a hunting weapon than flintlocks, meaning there's a valid niche that this can reasonably fit into.
If one of us also makes reproduction loads that use a small amount of smokeless powder a thing it'll get even more usable, since players would be able to take advantage of powder scavenged from unused modern ammo they find. Much like how the makeshift overpressure rounds for .36 and .44 in Cataclysm++ make for a massive boost in how usable the Colt Navy and Army are.