Repair Nanobots properly accounts for splints and mutations #2712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to check for splint and REGEN_LIZ, and this is easier than erasing them.
KheirFerrum
force-pushed
the
repair-nanobot-fix
branch
from
4abe1ed to
e5be0bd
Compare
scarf005
requested changes
May 3, 2023
scarf005
reviewed
May 3, 2023
There was a problem hiding this comment.
Confirmed that repair nanobots work with splints on
Confirmed that repair nanobots do not work with splints on
Confirmed that repair nanobots work without splints with lizard regeneration
Found bug:
mending percentage is not shown with repair nanobots (on) and lizard regeneration. it abrubtly shows that the limb is mended.
2023-05-03.21-46-19.mp4
|
I had thought that it not displaying with Lizard Regen was intentional so I didn't touch it. Will put up a fix. |
KheirFerrum
force-pushed
the
repair-nanobot-fix
branch
from
dad95d2 to
4bd0654
Compare
Reptillian Healing now updates display for broken limb. Replace "SPLINT" with flag_SPLINT. Updates bionic description
KheirFerrum
force-pushed
the
repair-nanobot-fix
branch
from
4bd0654 to
95a7c5c
Compare
scarf005
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Repair Nanobots properly accounts for splints and mutations"
Purpose of change
In #2482 I used
get_all_effects_of_type()for the mending list when refactoring it. This failed to account for lizard regen or splints as in the original implementation I used.Also feels like Repair Nanobots drains really fast, so I'm tuning it down unless anyone has objections.
Describe the solution
Do it again while retaining
std::vector<effect *> mending list.Also, it feels like the Repair Nanobots drain really fast and work really fast, turned it up to 2 minutes.
Describe alternatives you've considered
Apply
erase_if()to the vector.Testing
Install Repair Nanobots, increase bionic power to 100kJ, do not turn on. Break limb, wear splint, wait 30 minutes.
Additional context