Rule of Cool explosions v0.2: animation system fixes #2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
JSON
DeltaEpsilon7787
force-pushed
the
roc_v0.2_expl_fixes
branch
from
91e6d03 to
99fdc3e
Compare
DeltaEpsilon7787
force-pushed
the
roc_v0.2_expl_fixes
branch
from
874bbe8 to
47fe8fb
Compare
scarf005
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: [Performance] "Explosion animation speed made consistent with animation delay"
Purpose of change
Addresses and closes #2698. Additionally makes 0 animation delay not animate the explosion at all.
Also a number of bugfixes related to Made of Explodium update (#2601).
Describe the solution
Explosion animation system uses wall clock to time events instead of relying on nanosleep which disregarded rendering overhead, causing animation delay option to have a non-linear relationship with actual animation speed.
Describe alternatives you've considered
#2699
Testing
Check "rule of cool explosion merge conflict resolving" thread in BN Discord.
Additional context
N/A