Magic.md documentation update #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made sure all the formatting looked good. Made sure the new additions looked good on github.
chaosvolt
approved these changes
Apr 21, 2023
|
i always thought it was the same from CDDA doc, but only without giving info about the stuff BN still hasnt ported |
|
I haven't verified the differences between the DDA and BN docs to know that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: [Infrastructure] "Update Magic documentation with recent discoveries"
Purpose of change
The magic documentation is lacking a fair bit of details that I discovered through trial and error, plus pestering Chaosvolt on discord. I'd like to add some of these revalations to the documentation so others can have a better idea of what they're doing.
Describe the solution
I have updated target attack to explain negative damage will heal a target, that when using spawn item the damage specified determines quantity of items given, and that mutations can grant spells.
Describe alternatives you've considered
Keeping magic as much a mystery in the documentation as it is in any fantasy setting. Revamping the entire magic document from the ground up to be as clear and concise as possible.
Testing
I checked my changes on Github and made sure they still worked. I also made sure they open in a text editor (Given I used one to make the changes)
Additional context
How did I get here?
EDIT: Edited a typo in the solution.