-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworks and Reintroduced Micro Reactor & Radiation Scrubber CBM's #2663
Reworks and Reintroduced Micro Reactor & Radiation Scrubber CBM's #2663
Conversation
Should the radiation be constant, even when not supplied with fuel or otherwise in use? Seems more fitting for it to apply bursts of radiation when used, to properly make it an "oh shit" powergen option with consequences when the situation is dire enough to rely on. EDIT: After discussion about it on the BN discord, it's probably fine aside from maybe being good to have it only apply when it actually has fuel in it. |
Just put this on hold for a little bit, going to rework the rework radiation scrubber too and add another setting to the reactor |
would love the reactor to perpetually generate small amount of energy on default like IRL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, using descriptive commit names makes it clear what the commit does and helps both author and reviewer identify changes quickly.
… turn & unused varrible cleaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Compiled and load-tested.
- Installed a ton of power storage CBMs before adding micro-reactor.
- Waited a while, observed that no radiation or power generation occured without fuel.
- Loaded a single plutonium cell in, waited a while to confirm power generation and radiation occured.
- Turned it on, observed that power generation is 10 kj per turn.
- Debugged in the upgrade CBM and installed it, confirmed it converts the normal reactor to advanced, and that you still only have one copy of the override CBM on you.
I'm not yet 100% sure about the amount of passive powergen it gives, since you can get the same amount of power you'd get out of burning that cell just by waiting a lil over an hour, and even faster for the advanced version. I'd be tempted to suggest 50 and 100 watts for the passive powergen instead, that leaves it still a constant source of free energy but makes the choice to burn it a much more tantalizing prospect in comparison.
from 500J & 1kJ to 50J & 100J
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. could you try JSONizing persistent powergen for reactors sometimes later? or would it be unneccesary because there's few permagen CBMs?
Summary
SUMMARY:[Content] "Reworks micro reactor & radiation CBM's and adds the reactors back to the drop table"
Purpose of change
To fill a gap in high tech power generation CBM's
Describe the solution
Edit : a * represents a revision edit
Micro Reactor
500 J50 J of power while fueled for no costAdvanced Micro Reactor
1 kJ100J of power while fueled for no costRadiation Scrubber CBM
- lowers radiation produced by the Micro Reactor by half and completely stops radiation of the Advanced Micro Reactor*Reactor Safety Override
Testing