Broken Generator deconstruct port from DDA #2656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broken generator deconstructible, changed pipe fittings to scrap metal as it doesn't exist.
scarf005
requested changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Balance "Ported the Broken Generator deconstruct from DDA"
Purpose of change
The broken generator is one of few furnitures/furniture terrains that have no deconstruct recipe. This ports the DDA deconstruct.
Describe the solution
I copied their deconstruct recipe but replaced pipe fittings with 0-1 scrap metal as this item does not exist in BN.
Describe alternatives you've considered
Changing the resulting items so it doesn't give a whole plastic jerrycan. Leaving it as smashing required.
Testing
I opened the game with the changes and successfully deconstructed a broken generator for parts. No crashes or errors.
Additional context
If I run into any other common furnitures that isn't deconstructible but should, I'll be sure to tackle them.