Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: port std::moving items #2532

Merged
merged 2 commits into from
Apr 6, 2023
Merged

perf: port std::moving items #2532

merged 2 commits into from
Apr 6, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Apr 1, 2023 •
edited
Loading

Summary

SUMMARY: Performance "Use move semantics for some items in profession and inventory"

Purpose of change

@github-actions github-actions bot added the src changes related to source code. label Apr 1, 2023
@scarf005 scarf005 changed the title port std::moving items port std::moving items Apr 5, 2023
@scarf005 scarf005 changed the title port std::moving items perf: port std::moving items Apr 5, 2023
olanti-p
olanti-p approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@olanti-p olanti-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, though I'm pretty sure #2250 implements this on a wider scale.

@scarf005 scarf005 merged commit 5ca0c82 into cataclysmbnteam:upload Apr 6, 2023
@scarf005 scarf005 deleted the move-item branch April 6, 2023 22:51
@scarf005 scarf005 mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olanti-p olanti-p olanti-p approved these changes

Assignees
No one assigned
Labels
src changes related to source code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarf005 @olanti-p @BrettDong