Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use SI units as the default option #2510

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Mar 31, 2023

Summary

SUMMARY: Interface "Change interface to use SI units as the default"

Purpose of change

give a small nudge to use SI units by setting it to be default.

  • metric system is the global standard for measurement
  • help players from countries outside US
  • existing users wouldn't have to modify settings (probably)

Describe the solution

changed defaults as following:

Unit Before After
temperature fahrenheit celsius
speed mph km/h
mass lbs kg
distance imperial metric

Describe alternatives you've considered

port over DDA's

Testing

after build, checked on settings and new defaults were correct.

Additional context

blocked by #2517 until 2023-04-08 12:00:00 UTC+09:00

@github-actions github-actions bot added the src changes related to source code. label Mar 31, 2023
@chaosvolt
Copy link
Member

Probably fair since the defaults are already a weird mix of both US and Metric measurements.

@Firestorm01X2
Copy link
Collaborator

I recommend to also check time format.

@scarf005
Copy link
Member Author

scarf005 commented Mar 31, 2023

iirc 12h is also used globally in par with 24h, so i haven't modified it.

@Zireael07
Copy link
Contributor

Actually it's a little more complex than that... https://en.wikipedia.org/wiki/24-hour_clock#/media/File:12_24_Hours_World_Map.svg

Either is fine imho

@scarf005 scarf005 marked this pull request as draft March 31, 2023 14:34
@scarf005 scarf005 marked this pull request as ready for review April 8, 2023 03:18
@scarf005 scarf005 requested a review from Coolthulhu April 9, 2023 08:20
@Coolthulhu
Copy link
Member

I'd prefer the locale detection option.
If it's much more work, we could have a poll or something.

@scarf005
Copy link
Member Author

scarf005 commented Apr 9, 2023

I'd also prefer the locale detection but I won't be able to reliably test neither on mac nor windows.
judging by result from poll #2517, it looks like majority prefers SI units as default.

@Coolthulhu
Copy link
Member

judging by result from poll #2517, it looks like majority prefers SI units as default.

Alright, it's OK to merge this then.

@scarf005 scarf005 changed the title Use SI units as the default option feat: use SI units as the default option Apr 10, 2023
@scarf005 scarf005 merged commit ffcc9ba into cataclysmbnteam:upload Apr 10, 2023
@scarf005 scarf005 deleted the default-metric branch April 10, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants