-
Notifications
You must be signed in to change notification settings - Fork 326
Superalloy Survivor Gear #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superalloy Survivor Gear #2458
Conversation
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for creating PR. a few things to note:
-
please run
make style-json
before creating PR. they will format jsons for you. for example, these 5 suggestions are outputs from said command. you may also want to read how to do it in visual studio. -
next time, please create a new branch from
upload
, often called as the main branch. committing directly to main can lead to conflicts and merge issues. for example, next time you try togit pull
, it will spit out 'merge conflict' because you've modified local main and git cannot figure out whether to keep the local one or remote one. the best practice is to use branches for development, so each changes are safely contained.
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
I'll keep this in mind. Still need to get a handle on editing through visual studio. This was done through Git as a cut/paste job of heavy survivor stuff and changing what was necessary. Feel kinda of silly letting those spaces slip through.
Thank you, will do. |
You can also use: http://dev.narc.ro/cataclysm/format.html |
Decided to base Superalloy sheet cost off MBR vest. It takes 8 SA sheets to fill one MBR vest with 85% coverage. SA survivor suit fully covers the torso + arms + legs. Went with a rough approximation of 26 SA for a regular suit and 32 for the noticeably large XL variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @FlameStormer2000, i apologize for the delay, i may have missed the notification.
also, you can re-request reviews by clicking refresh button on the right.
overall, PR's looking good but may i suggest to adjust values to be more metric-oriented?
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
All good, meant to ping you after my crafting cost edits but forgot over the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! thank you for the contribution.
Summary
Add a line of superalloy survivor gear which has defensive stats equal to heavy survivor gear but is lighter and less encumbering due to being made from superalloy instead of steel.
Purpose of change
Superalloy is currently underutilized almost to the point of non-existence as a crafting material. I hope this can be the first step towards making superalloy more sought after as a relatively rare but useful crafting material for lategame items.
Describe the solution
All superalloy survivor gear is 40% lighter and 5 less encumbering than heavy survivor equivalents. This is inline with the stat difference between MBR vests (steel) and (superalloy). It also requires 2 additional levels of fabrication to craft compared to heavy survivor gear due to more difficulty working with superalloy.
Describe alternatives you've considered
Not adding these. I think ingame/universe wise superalloy gear would be something worth pursuing by a survivor with the skill to craft it due the obvious potential weight savings.
Testing
Compiled and ran. Checked that recipes are automatically learned at appropriate level. Stats are inline with heavy survivor.
Additional context
Superalloy is currently very rare without the ability to disassemble limb alloy CBMs. I only know of the aforementioned superalloy MBR vest (which might not even spawn anymore?) as a source and that putting an electric supercar engine into the Steel Mill recycler yields an obscene amount. I'd like to add more appropriate sources of superalloy in the future to encourage more recipes to use it.
The balance of how many sheets it should take to craft these is also something I'm open to changing. I considered a volume conversion compared to steel chunk/scrap but it felt kinda off.