-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character code reorganization 09-jan-2023 #2283
Merged
Coolthulhu
merged 24 commits into
cataclysmbnteam:upload
from
olanti-p:code-reorg-09-jan-2023
Feb 13, 2023
Merged
Character code reorganization 09-jan-2023 #2283
Coolthulhu
merged 24 commits into
cataclysmbnteam:upload
from
olanti-p:code-reorg-09-jan-2023
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
src
changes related to source code.
tests
changes related to tests
labels
Jan 9, 2023
olanti-p
changed the title
Character code reorganization 09-jan-2023
[WiP] Character code reorganization 09-jan-2023
Jan 9, 2023
olanti-p
changed the title
[WiP] Character code reorganization 09-jan-2023
Character code reorganization 09-jan-2023
Jan 11, 2023
olanti-p
force-pushed
the
code-reorg-09-jan-2023
branch
from
January 19, 2023 21:19
be913ac
to
b63059a
Compare
Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Reorganized some Character-related code"
Purpose of change
Dismantling
player
.Describe the solution
See commits.
player
intoCharacter
player
and turn them into namespaced functionsCharacter
and turn them into namespaced functionsreload_option
out ofitem
to allow forward declaring itg->u
Testing
Game compiles. No behavior changes intended.
TODO:
Additional context
I don't like how
creature.cpp
is growing here, may need to split it up later