-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge inherited workflows, utilities and build files #2213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olanti-p
changed the title
Purge inherited worflows, utilities and build files
Purge inherited workflows, utilities and build files
Nov 29, 2022
Has conflict with the MXE update. It seems non-trivial, so I'll leave it for now. |
olanti-p
force-pushed
the
remove-unused
branch
from
December 11, 2022 17:13
a5be21e
to
7b205c8
Compare
Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Purge inherited workflows, utilities and build files"
Purpose of change
We have inherited many files that are being used (or were used at some point in the past) by DDA, but have no meaning for BN, or are not correct for BN, or are simply obsolete. This PR aims to get rid of the most visible ones.
Closes #2086
Describe the solution
Removed the following files and workflows:
It used to be used for Visual Studio builds, but now we have msvc builds in Github Actions.
DDA uses it for code analysis, but we don't use it in any capacity.
It needs to be updated for BN, and maybe updated overall, before it becomes useful. Also, shouldn't we need to register on flathub first?
Needs BN-ification, didn't test whether it works.
Needs BN-ification, didn't test whether it works.
We don't use Jenkins, and most likely never will. DDA moved PR validation workflow to GA, so if we'll need it we could port it.
It's reportedly been dead for years, didn't test whether it works.
We've moved away from Travis to GA and most likely won't be coming back. Travis parts in the workflow are just dead code by this point.
This seems to be a one-off experiment not documented anywhere and not updated since it's creation; I tried building it and it fails.
It describes issue labels used by DDA repo, we don't use these.
Need to be BN-ified, also may be outdated (they received some maintenance updates in DDA over the last couple years).
They've been without maintenance for years, and as far as I can tell are not mentioned in documentation, so the only way you'll use them is if you luckily stumble on them in game files. We have a handy
--help
command line argument that provides an up-to-date info on arguments, andREADME.md
that gives up-to-date introduction and feedback info.We don't use Jenkins, and we don't enforce (or validate) PR summaries, so it's kinda useless without these. Right now the stable changelog is done by hand, and experimental changelog is done by GA.
This is for alerting DDA team members about changes in DDA code, neither part has anything to do with BN.
We don't use stalebot, and there are no plans for it (yet?)
It's not mentioned in docs, so I'm not sure whether anyone has ever used it for BN (or whether it even works). Either way, many flags don't have "context" field specified properly for it to work, and that JSON file is quite clean and readable, so I'm not sure whether it needs a separate documenting mechanism.
From discussion in Change all instances of "volume" in JSONs to be a metric string CleverRaven/Cataclysm-DDA#33367, it seems to be redundant to
tools/json_tools/adjust_values.py
. I'd rather keep the python script, as most of our script tooling is in python.Describe alternatives you've considered
Some of this stuff could be BN-ified and brought back into working order, sure, but it's been 2 years and noone cared enough (or felt the urgency) to deal with the bitrot. If someone volunteers to fix it, it could be left in, or, better, be removed now and then un-removed in the PR that would also have the relevant fixes.
Testing
Travis removals are pretty close to working parts of GA workflow, I've run clang-tidy-on-PR and experimental release actions on a fork and it didn't break, that should be enough.