Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] spawn updates #2168

Merged
merged 4 commits into from
Dec 17, 2022
Merged

[DinoMod] spawn updates #2168

merged 4 commits into from
Dec 17, 2022

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Nov 6, 2022

Summary

SUMMARY: Mods "[DinoMod] spawn updates"

Purpose of change

Update BN content to parity with DDA as much as possible

Describe the solution

Ports DinoMod wilderness spawns as of CleverRaven/Cataclysm-DDA#51862 and misc spawns as of CleverRaven/Cataclysm-DDA#50446 both just before the giant monstergroup rework in DDA

Main differences are gorgosaurus and sewer spawns, otherwise pretty samey to current game state, not as impactful as hoped.

Describe alternatives you've considered

Manually rework all wilderness spawns since September 2021 until port requests are merged, wait until monster group port requests happen

Testing

Game loads no errors, monsters spawn as expected

Additional context

Small step forward in spawning the new dinos added recently

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Nov 6, 2022
@LyleSY LyleSY marked this pull request as ready for review November 6, 2022 12:44
@Coolthulhu Coolthulhu self-assigned this Nov 15, 2022
data/mods/DinoMod/monstergroups/misc.json Outdated Show resolved Hide resolved
data/mods/DinoMod/monstergroups/misc.json Outdated Show resolved Hide resolved
@olanti-p
Copy link
Contributor

olanti-p commented Dec 9, 2022

Got a debug message while testing, though it seems unrelated to this PR

Tried to get invalid harvest list: CBM_DINO_FEATHER

@LyleSY
Copy link
Contributor Author

LyleSY commented Dec 9, 2022

Good call, I've made those changes. It looks like one of the big PRs knocked out the CBM harvest lists. I'll dig into that in a later PR

@Coolthulhu Coolthulhu merged commit 66fe753 into cataclysmbnteam:upload Dec 17, 2022
@LyleSY LyleSY deleted the dinomod_spawns branch December 17, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants