Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overmap_debug_mongroup debugmsg on save+load #2117

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

Coolthulhu
Copy link
Member

Summary

SUMMARY: Bugfixes "Fix overmap_debug_mongroup debugmsg on save+load"

Purpose of change

One of the recent PRs added a field, a line to save it, but no line to read it. This caused a debugmsg on load. This PR adds the line to read the field.

Describe the solution

As above.

Describe alternatives you've considered

Don't save the field.

Testing

  1. Save
  2. Load the just saved game
  3. No debugmsg

Additional context

@KheirFerrum
Copy link
Collaborator

KheirFerrum commented Oct 24, 2022

Oh, crap, this is one of mine, it's one of the remnants of the Distraction Manager from #2089.

The variable may be read but it's not currently used by anything.

It should just be deleted from line 4294 of savegame_json.cpp

@scarf005 scarf005 added the src changes related to source code. label Oct 26, 2022
@Coolthulhu Coolthulhu self-assigned this Oct 30, 2022
@Coolthulhu Coolthulhu merged commit adecdd1 into upload Oct 31, 2022
@olanti-p olanti-p deleted the save-debugmon-fix branch March 24, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants