Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDA Port] Fix various issues with window redraw and event handling #2016

Merged
merged 7 commits into from
Oct 21, 2022

Conversation

olanti-p
Copy link
Contributor

Summary

SUMMARY: Bugfixes "[DDA Port] Fix various issues with window redraw and event handling"

Purpose of change

Fix window getting unresponsive on long operations.
Fix #2015

Describe the solution

Stuff being ported:

Describe alternatives you've considered

That single clear call should've been enough, but I've decided to go an extra mile and port fixes for related issues.

Testing

Can no longer repro the bug with the repro steps described in linked issue.

@Coolthulhu Coolthulhu self-assigned this Oct 15, 2022
Qrox added 4 commits October 20, 2022 23:57
(cherry picked from commit c63eb252ceb547955dbfa61ea86ef6dce854a945)
(cherry picked from commit f268c73ed9d714427e219047955b63c2403513fd)
(cherry picked from commit 7152aef950c7eef9ae259a5536e4c324074754b4)
(cherry picked from commit 86f487f06780cbd1d229c028baef1d4fc51accb9)
@olanti-p olanti-p force-pushed the port-misc-windowing-fixes branch from 6cbfa26 to 3656868 Compare October 20, 2022 21:04
MalteT and others added 3 commits October 21, 2022 00:11
(cherry picked from commit 64c9f17d1d47d3c42005e8d5bb32a4d1fe2a371b)

Co-authored-by: andrei <68240139+andrei8l@users.noreply.github.com>
@olanti-p olanti-p force-pushed the port-misc-windowing-fixes branch from 3656868 to e34396d Compare October 20, 2022 21:11
@Coolthulhu
Copy link
Member

Wow, the implementation is ugly. bool params (with default values), direct calls to global input manager from unrelated classes, functions with over 3 bool params...

I guess it's OK for now, but it's a big // TODO: Refactor.

@Coolthulhu Coolthulhu merged commit f9c656e into cataclysmbnteam:upload Oct 21, 2022
@olanti-p olanti-p deleted the port-misc-windowing-fixes branch October 24, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glitchy area at the bottom of graphical window
4 participants