Make grave inscription text prompt readable #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
requested changes
Oct 12, 2022
Co-authored-by: scarf <greenscarf005@gmail.com>
casswedson
pushed a commit
to casswedson/Cataclysm-DDA
that referenced
this pull request
Oct 13, 2022
from cataclysmbnteam/Cataclysm-BN#2009 Co-authored-by: scarf005 <scarf005@users.noreply.github.com>
dseguin
pushed a commit
to CleverRaven/Cataclysm-DDA
that referenced
this pull request
Oct 14, 2022
from cataclysmbnteam/Cataclysm-BN#2009 Co-authored-by: scarf005 <scarf005@users.noreply.github.com> Co-authored-by: chaosvolt <chaosvolt@users.noreply.github.com> Co-authored-by: scarf005 <scarf005@users.noreply.github.com>
scarf005
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Text prompt for inscribing during burial no longer only 3 characters wide"
Purpose of change
Burying coffins had a major problem with the text prompt being effectively unreadable:
Describe the solution
iuse::handle_ground_graffitinow places the text entry below the prompt via a newline, giving it more space to make text entered easier to read and edit.Describe alternatives you've considered
If I could figure out some way to have basically a newline after the text prompt's title and the text entry, so it'd look neater, that'd be even better. I couldn't find any sign of a way to do that withScarf knew how to do that so we have that now. :Dstring_input_popupthough.Testing
Additional context