Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid flag to more specials, mods in particular #1999

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Content "Added electric grid flag to saw mills, relevant mod locations"

Purpose of change

This started as just something someone requested over on the BN discord, as it came up that with #1866 being merged we can probably justify adding the ELECTRIC_GRID flag to at least a couple more locations we would've avoided earlier, and then roll them back in favor of partial grid coverage once we have support for junction boxes.

This quickly got derailed by me realizing we oughta check mods for any overmap specials obviously in need of the grid flag too, as presently it looks like only No Hope has gotten to make use of it so far.

Describe the solution

Added ELCTRIC_GRID flag to lumber mills, per request. Normally I'd avoid doing this since it does have a decent chunk of fields that exist only to be filled with trees, but this is hopefully acceptable until we have junction boxes implemented, and farms recently got a grid expansion to set a precedent for erring on the side of "grid support now over waiting for the ability to only grid up part of a special".

Additionally, finally remembered to check in-repo mods and added the flag to:

  • Municipal reactors (Aftershock)
  • Variant mortuary (Aftershock)
  • Whately LMOE shelter (Aftershock)
  • Robot dispatch (Aftershock)
  • Dino exhibit (Dinomod)
  • Dino microlab (Dinomod)
  • Magic cabin (Magiclysm)

Describe alternatives you've considered

  • Adding it to Magiclysm's Lake Retreat, currently not changed since it has a BIG chunk of open lake, while I could justify electrifying it wasn't sure what performance impact might be.
  • Adding it to Fuji's Structures, More Locations, National Guard Camp, and Salvaged Robots specials too, those are obsoleted mods though.

Testing

Checked affected files for syntax and lint errors.

Additional context

@Coolthulhu Coolthulhu self-assigned this Oct 11, 2022
@Coolthulhu Coolthulhu merged commit 988b8c9 into cataclysmbnteam:upload Oct 15, 2022
@chaosvolt chaosvolt deleted the mills-go-zap branch October 15, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants