Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While flying, warn when letting go of control or stop driving #1952

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 4, 2022

Summary

SUMMARY: Bugfixes "While flying, warn when letting go of control or stop driving"

Purpose of change

Describe the solution

when trying to let go of control or stop driving while flying, warn "Really let go of controls while flying? This will result in a crash."

Describe alternatives you've considered

  • make helicopters be able to fly without controls
  • automatically land

either way won't take less than two ifs.

Testing

it works on my machine!

Additional context

Letting go of Control _04 _05

Stopping Engine _06 _07 _08

src/vehicle_use.cpp Outdated Show resolved Hide resolved
@scarf005 scarf005 requested review from Coolthulhu and removed request for Coolthulhu October 5, 2022 08:22
@scarf005 scarf005 changed the title While flying, do not allow letting go of control or stop driving While flying, warn when letting go of control or stop driving Oct 5, 2022
@Coolthulhu Coolthulhu self-assigned this Oct 5, 2022
src/vehicle_use.cpp Outdated Show resolved Hide resolved
src/vehicle_use.cpp Outdated Show resolved Hide resolved
@scarf005 scarf005 force-pushed the dont-crash-midair branch 2 times, most recently from 937f8ce to 800294c Compare October 6, 2022 04:00
@olanti-p
Copy link
Contributor

olanti-p commented Oct 9, 2022

Tidy complains

/home/runner/work/Cataclysm-BN/Cataclysm-BN/src/vehicle_use.cpp:617:56: error: insufficient spaces at this location.  2 required, but only 1 found. [cata-text-style,-warnings-as-errors]
            _( "Really let go of controls while flying? This will result in a crash." ) );
                                                       ^
                                                        

@olanti-p olanti-p merged commit 1cbe10f into cataclysmbnteam:upload Oct 10, 2022
@scarf005 scarf005 deleted the dont-crash-midair branch October 25, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning before stopping engine when flying
3 participants