-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickfix for sweetbread missing from offal_raw #1916
Conversation
Damn, that pancreas do got hands tho.
Okay, so now we have what should be a basic one-line fix instead being more complicated because the test is being weird. First it was complaining because 2 sweetbread seemed to be too much, but this latest test failure makes zero sense:
It already has two high-calorie offal items and several low-calorie ones, an in-between ingredient shouldn't screw things up that readily. Especially since PREVIOUSLY sweetbread was used in the offal crafting requirement with no weird effects. |
It calculates standard deviation, meaning every point close to the mean makes it want less variance. |
Ah, weird. Any idea on how to enable it to pass the test while still letting sweetbread work in the recipe again? |
We probably should rework the test to have some minimum spread. |
Ah, hmm. Not sure how to go about that, nor if that'd be out of scope for this fix. |
* Reverted the change to how much sweetbread is used, because the test that the original commit is less CBT to try and fix. * Per Coolthulhu's suggestion on the discord, adjusted how comestible_test.cpp works to make the range more forgiving.
Reverting the change to the comestible test, this seems to need to be a separate PR as it's going to be bigger than the intended one-line change to allow sweetbread. |
Summary
SUMMARY: Bugfixes "fix sweetbread not being usable in offal recipes, make comestible_test.cpp more forgiving"
Purpose of change
Quick fix for a thing I just now noticed got missed during #1371, sweetbread was axed from the new crafting requirement by accident.
Describe the solution
Re-added sweetbread to the
offal_raw
crafting requirement, also added a suggested tweak to one of the tests along the way. Basically less use of standard deviation in favor of a fixed (more forgiving) distance away from default calories.Describe alternatives you've considered
Procrastinating until Coolthulhu does it.
Testing
Checked affected file for syntax and lint errors.
Additional context
How the fuck did I not notice that when I looked over that PR, I thought I eyeballed it for the sake of grabbing offal item IDs for the follow-up PR (#1519)...