Port over fix for spellcasting monsters and summon spells

[chaosvolt]

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Summary

SUMMARY: Bugfixes "Port over minor code fix to monster spellcasting"

Purpose of change

@thelonestander was asking me about a code fix needed for his implementation of flesh raptors in a mod for BN, to fix an issue where monsters casting summoning spells would always magic them right next to the player.

Describe the solution

Ported over update from DDA fixing mon_spellcasting_actor::call in mattack_actors.cpp, to be able to cite the position of themselves as well from what I understand of the change.

Describe alternatives you've considered

1. Pestering Lone to do it when he finally escapes Florida and can return to making PRs.
2. Also porting over flesh rapters, dunno how well it'd work nor what niche it'd really fit other than "generic pest creator"

Testing

1. Compiled and load-tested.
2. Temporarily added Lone's BN port of flesh raptors from https://github.com/thelonestander/Lones-Tech-and-Weapons-mod
3. Skipped load errors from Lone accidentally retaining shape in the relevant spells.
4. Spawned in pupataing zeds.
5. Confirmed that when they go off the raptors spawn near the corpse instead of being plonked down next to the player.
6. Added mod to re-test in an existing release (2022-09-18-1931), confirmed that behavior without this PR's change spawns them in your face instead.

Additional context

Source PR by Erk: CleverRaven/Cataclysm-DDA#43350

[Coolthulhu]

Compiled and load-tested. I don't know if we have any good examples of a monster to test this with, though I could go grab Lone's implementation of flesh rapters as a BN mod to test with.

You should at least add a test monster for those cases.

[chaosvolt]

You should at least add a test monster for those cases.

Not sure what would fit for this. A whole debug-only test monster written into the JSON for keeps, for a one-line change, would be a bit weird. I can snag Lone's mod and drop it in for a quicktest, though?

EDIT: Went ahead with said test using Lone's flesh raptor portover mod.

[Coolthulhu]

A whole debug-only test monster written into the JSON for keeps

Those are useful for showing things, yeah. We do have debug_monster, after all. Teleporting debug monster, summoning debug monster (not sure what could it summon - preferably something that dies on its own, so that it can summon more) - those aren't just there for the tests, they are something that you can point at and tell a contributor:

Here's how you use this feature.

[chaosvolt]

True, guess I could mess with it when I get back home. Alternatively, I could mess with rigging the maddened summoners in Arcana to spawn their monsters around them instead of near the player, since it is planned to be an in-repo mod eventually, though that'd run afoul of the mutual-dependency problems holding up #1823 at the moment.

[Coolthulhu]

Still needs an example.

[chaosvolt]

Hecc. Can either follow up on this with an example in a PR or rework maddened summoners into an example that'll be usable when Arcana is PR'd as an in-repo mod.