Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDA Port] Show number of monsters in sidebar compass #1825

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented Sep 1, 2022

Summary

SUMMARY: Interface "[DDA Port] Show number of monsters in sidebar compass"

Purpose of change

One of the popular port requests, show # of monsters in the compass above the minimap.

Describe the solution

Cherry-pick CleverRaven/Cataclysm-DDA#49737

Testing

image

Additional context

Surprisingly, it had no conflicts.

@Coolthulhu Coolthulhu self-assigned this Sep 2, 2022
@Coolthulhu
Copy link
Member

Conflicts with #1802, I'll start with #1802.

@Coolthulhu Coolthulhu removed their assignment Sep 2, 2022
@RelMayers
Copy link
Contributor

How this would affect like 120x30 compass behaviour?

@olanti-p
Copy link
Contributor Author

olanti-p commented Sep 2, 2022

What do you mean by that, @RelMayers? We don't have extensive sidebar customization from newer DDA versions, the widest it ever gets is 44 symbols.

@RelMayers
Copy link
Contributor

i meant window size 120x30

(cherry picked from commit 9ac7bd0f5e23c64b3abb496c2aa1b6fc831c3641)
@olanti-p
Copy link
Contributor Author

olanti-p commented Sep 6, 2022

The only change this PR introduces is that each monster will have a number appended before its name. It will make each "symbol: meaning" pair take a couple more cells for the number, but that's expected.

I don't see any particular special behavior for when the window size is 120x30
image
Before the change, for comparison:
image
It works same on 192x49 window size.

@RelMayers
Copy link
Contributor

RelMayers commented Sep 9, 2022

There seems to be using more space, but seems like there isn't any meaningful change due to already reserved space for it. Thank you for checking my concern I'm glad for it.

@Coolthulhu Coolthulhu self-assigned this Sep 9, 2022
@Coolthulhu Coolthulhu merged commit 115c3ae into cataclysmbnteam:upload Sep 9, 2022
@olanti-p olanti-p deleted the port-compass branch September 9, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants