Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix procedural mine mapgen overwriting exit location #1808

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

olanti-p
Copy link
Contributor

@olanti-p olanti-p commented Aug 25, 2022

Summary

SUMMARY: Bugfixes "Fixed procedural mine mapgen overwriting exit location"

Purpose of change

Fix #1643

Describe the solution

Shuffle to nearest empty_rock omt before starting placement.
This means is some rare cases "bottom" procgenned parts can be disconnected from "top" procgenned parts, but that's better than current situation and should affect starting characters only.

Also fixed off-by-one position of mine shaft ladder to manhole exit.

Describe alternatives you've considered

Porting CleverRaven/Cataclysm-DDA#56555 would be ideal, but it uses mutable overmap specials which we don't have (I'd love to see them ported at some point as well though).

Testing

Teleported around the world, so no new mines generated with their -2 offloading room overwritten.

@Coolthulhu Coolthulhu self-assigned this Aug 26, 2022
@Coolthulhu Coolthulhu merged commit b5088e4 into cataclysmbnteam:upload Aug 28, 2022
@olanti-p olanti-p deleted the fix-mine-trap branch August 28, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mine Entrance location is broken
2 participants