Upgrade Catch2 library to v2.13.8 #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelicosPhosphoros
force-pushed
the
upgrade_catch_2
branch
from
659b650 to
27b197f
Compare
Older version was [problematic](catchorg/Catch2#2272) during C++20 migration so I updated library version. Decided to make it different PR because C++20 migration appears to be not so easy as I thought so I decided to split away complete parts. I just copied their file from [their release](https://github.com/catchorg/Catch2/releases/tag/v2.13.8) in github. I edited one variable name in their code because it clashed with our translation define (changed it from `_` to `__`). Also removed catch.h from clang-tidy checks
AngelicosPhosphoros
force-pushed
the
upgrade_catch_2
branch
from
27b197f to
ebe2012
Compare
joveeater
pushed a commit
to joveeater/Cataclysm-BN
that referenced
this pull request
Jul 10, 2022
Older version was [problematic](catchorg/Catch2#2272) during C++20 migration so I updated library version. Decided to make it different PR because C++20 migration appears to be not so easy as I thought so I decided to split away complete parts. I just copied their file from [their release](https://github.com/catchorg/Catch2/releases/tag/v2.13.8) in github. I edited one variable name in their code because it clashed with our translation define (changed it from `_` to `__`). Also removed catch.h from clang-tidy checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Upgrade Catch2 library to v2.13.8"
Purpose of change
Older version was problematic during C++20 migration so I updated library version. Decided to make it different PR because C++20 migration appears to be not so easy as I thought so I decided to split away complete parts.
Describe the solution
I just copied their file from their release in github.
I edited one variable name in their code because it clashed with our translation define (changed it from
_to__).Also removed catch.h from clang-tidy checks.
Describe alternatives you've considered
Testing
Additional context
Excluded
catchfrom clang-tidy because it is third-party library.