Refactor power grid traverse code #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelicosPhosphoros
force-pushed
the
improve_veh_grid_traverse
branch
from
d6f0938 to
f108f5e
Compare
|
Experience of configuring Visual Studio and building the game was great for C++ project, take only half a hour. My thanks to whoever who made it so easy. |
|
@Coolthulhu May you approve CI run? |
AngelicosPhosphoros
force-pushed
the
improve_veh_grid_traverse
branch
from
f108f5e to
40d7c60
Compare
|
Started the CI. Will mergetest with next batch, assuming nothing explodes. |
|
The builds complain about C++17 compatibility with Also |
I was randomly reading code and found this function confusing. Refactored for readability. * Split graph traversion and whatever caller wants to do with items. * Added comments in places where I failed to understand fast. * Removed `amount` updating from traversing and few hacks on call-sites caused by this. * Removed redundant "only vehicles" traversion method. * Removed raw pointers from public interface.
AngelicosPhosphoros
force-pushed
the
improve_veh_grid_traverse
branch
from
40d7c60 to
8b36799
Compare
|
@Coolthulhu runned astyle and removed noexcept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Refactor power grid traverse code"
Purpose of change
I was randomly reading code and found this function confusing. Refactored for readability.
Describe the solution
amountupdating from traversing and few hacks on call-sites caused by this.Describe alternatives you've considered
Testing
Additional context