chore: bump typescript to 4.5.4, and adjust storybook story. (apache#…

…17971) * chore: bump typescript to 4.5.4, and adjust storybook story to pass linting * ugh... missed a space. Thanks, linter :) * nixing erroneous package lock file
casual-precision · Feb 7, 2022 · 352efe3 · 352efe3
1 parent 6feaf80
commit 352efe3
Show file tree

Hide file tree

Showing 4 changed files with 118 additions and 120 deletions.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -321,7 +321,7 @@
     "transform-loader": "^0.2.4",
     "ts-jest": "^26.4.2",
     "ts-loader": "^9.2.5",
-    "typescript": "^4.1.6",
+    "typescript": "^4.5.4",
     "webpack": "^5.52.1",
     "webpack-bundle-analyzer": "^4.4.2",
     "webpack-cli": "^4.8.0",

diff --git a/superset-frontend/packages/superset-ui-demo/package.json b/superset-frontend/packages/superset-ui-demo/package.json
@@ -87,7 +87,7 @@
     "chromatic": "^5.4.0",
     "fork-ts-checker-webpack-plugin": "^5.0.7",
     "ts-loader": "^7.0.4",
-    "typescript": "^3.8.3"
+    "typescript": "^4.5.4"
   },
   "peerDependencies": {
     "@encodable/color": "=1.1.1"

diff --git a/superset-frontend/src/components/ModalTrigger/ModalTrigger.stories.tsx b/superset-frontend/src/components/ModalTrigger/ModalTrigger.stories.tsx
@@ -43,7 +43,7 @@ export default {
 };
 
 export const InteractiveModalTrigger = (args: IModalTriggerProps) => (
-  <ModalTrigger triggerNode={<span>Click me</span>} {...args} />
+  <ModalTrigger {...args} triggerNode={<span>Click me</span>} />
 );
 
 InteractiveModalTrigger.args = {