-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump typescript to 4.5.4, and adjust storybook story. #17971
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17971 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 1611 1611
Lines 64919 64919
Branches 6871 6871
=======================================
Hits 43548 43548
Misses 19504 19504
Partials 1867 1867
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the upgrade! I'll be honest, i'm a little concerned that:
- the superset-ui-demo has its own lockfile even though it's in a monorepo
- This added 45k lines to said lockfile
but if you double check and this is all as expected, lgtm!
4618e53
to
18c901a
Compare
18c901a
to
9d5dbcb
Compare
Thanks for the review @etr2460 - that package lock was accidental, and I'm glad you stopped to notice the gigantic file. |
…17971) * chore: bump typescript to 4.5.4, and adjust storybook story to pass linting * ugh... missed a space. Thanks, linter :) * nixing erroneous package lock file
…17971) * chore: bump typescript to 4.5.4, and adjust storybook story to pass linting * ugh... missed a space. Thanks, linter :) * nixing erroneous package lock file
SUMMARY
Saw that This PR was failing due to some esoteric linting issue in a storybook issue. This makes the same bump, also bumps Superset, and fixes the Story.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Verified Storybook works fine locally. CI passing should cover the rest.
ADDITIONAL INFORMATION