Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize role manager and add more rbac apis #20

Merged
merged 4 commits into from
Aug 26, 2019
Merged

Optimize role manager and add more rbac apis #20

merged 4 commits into from
Aug 26, 2019

Commits on Aug 25, 2019

  1. optimize default role manager 

    1. prefer to use iterator rather than for loop
2. remove unnecessary Rc::clone
    @xcaptain
    xcaptain committed Aug 25, 2019
    1 Configuration menu
    Copy the full SHA
    bc1c6e2 View commit details
    Browse the repository at this point in the history

  2. modify the definitions of add_link and delete_link 

    because domain can at most be 1 string, so use Option<&str>
rather than Vec<&str>
    @xcaptain
    xcaptain committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    f0c423c View commit details
    Browse the repository at this point in the history

  3. add_role_links() should return a Result<()> rather than panic 

    domain can at most contains 1 string
    @xcaptain
    xcaptain committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    07c258a View commit details
    Browse the repository at this point in the history

  4. add more rbac apis and tests

    @xcaptain
    xcaptain committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    0e3762e View commit details
    Browse the repository at this point in the history