Optimize role manager and add more rbac apis #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. prefer to use iterator rather than for loop 2. remove unnecessary Rc::clone
because domain can at most be 1 string, so use Option<&str> rather than Vec<&str>
domain can at most contains 1 string
|
@hsluoyz As discussed #9 (comment) I changed domain definition from |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 78.01% 82.79% +4.78%
==========================================
Files 4 4
Lines 282 279 -3
==========================================
+ Hits 220 231 +11
+ Misses 62 48 -14
Continue to review full report at Codecov.
|
This was referenced Aug 25, 2019
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is originally meant to fix suggestions at #9 but in later commits I added more rbac apis.