add missing implementation for casbin@0.3.0 and make unique key constraint works #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GopherJ
changed the title
|
@GopherJ why don't use the built-in services provided by Travis CI? Like how we did it in Xorm adapter: https://github.com/casbin/xorm-adapter/blob/79a2aa54a016320eb29cf90090f642183827750b/.travis.yml#L14-L16 |
|
hello @hsluoyz we are using it, but in dev I would like to have some scripts so I added these two scripts |
|
Got it. |
omid
reviewed
Mar 2, 2020
| .collect::<Vec<NewCasbinRule>>(); | ||
|
|
||
| conn.transaction::<_, DieselError, _>(|| { | ||
| diesel::insert_into(casbin_rules) |
There was a problem hiding this comment.
Do we need the transaction here? I think Diesel will generate one query.
There was a problem hiding this comment.
I was also thinking about this. But I'm not really sure about it. I'm not sure if it's one query or multiple. If it's one query we can then remove it.
There was a problem hiding this comment.
I'm also not 100% sure in every case 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR make unique key works for policy rules, before it cannot work because we do have nullable fields.
Now we are adding empty string to solve this issue.
Besides, it adds implementation of
add_policiesandremove_policiesusing diesel transaction.