Database transactions similar api addPolicies, removePolicies

[GopherJ]

See casbin/node-casbin#105

[GopherJ]

see #59

More unit tests need to be added around this, I'll add them when I got time. There are also many work regarding diesel-adapter.

It must be able to do transaction.

[drholmie]

Hey there! I'm interested in this issue and wanted to know if I can help out with the unit tests.

[GopherJ]

@drholmie Hello, thanks for being interested in this. Could you help testing the following methods?

    async fn add_policies(&mut self, paramss: Vec<Vec<&str>>) -> Result<bool>;
    async fn remove_policies(&mut self, paramss: Vec<Vec<&str>>) -> Result<bool>;
    async fn add_named_policies(&mut self, ptype: &str, paramss: Vec<Vec<&str>>) -> Result<bool>;
async fn remove_named_policies(&mut self, ptype: &str, paramss: Vec<Vec<&str>>)
        -> Result<bool>;
    async fn add_grouping_policies(&mut self, paramss: Vec<Vec<&str>>) -> Result<bool>;
    async fn remove_grouping_policies(&mut self, paramss: Vec<Vec<&str>>) -> Result<bool>;
  async fn add_named_grouping_policies(
        &mut self,
        ptype: &str,
        paramss: Vec<Vec<&str>>,
    ) -> Result<bool>;
 async fn remove_named_grouping_policies(
        &mut self,
        ptype: &str,
        paramss: Vec<Vec<&str>>,
    ) -> Result<bool>;
async fn add_permissions_for_user(
        &mut self,
        user: &str,
        permissions: Vec<Vec<&str>>,
    ) -> Result<bool>;
  async fn add_roles_for_user(
        &mut self,
        user: &str,
        roles: Vec<&str>,
        domain: Option<&str>,
    ) -> Result<bool>;

Currently we haven't make diesel-adapter supports this, ideally we should have diesel-adapter supports this by using transaction.

[drholmie]

Awesome! will start with the tests first then. Thank you for clarifying :)

[GopherJ]

diesel-adapter now has also:

async fn add_policies(
        &mut self,
        _sec: &str,
        ptype: &str,
        rules: Vec<Vec<&str>>,
    ) -> Result<bool>;

    async fn remove_policies(
        &mut self,
        _sec: &str,
        pt: &str,
        rules: Vec<Vec<&str>>,
    ) -> Result<bool>;

See casbin-rs/diesel-adapter#15

[hsluoyz]

Closed as resolved.

[drholmie]

Hey there @GopherJ wanted to clarify a few things. Firstly, should I open a new issue to better track the completion of tests? Secondly, should I also follow the double insert and remove checks as mentioned in the test_modify_policy_api():

...
        e.remove_policy(vec!["alice", "data1", "read"])
            .await
            .unwrap();
        e.remove_policy(vec!["bob", "data2", "write"])
            .await
            .unwrap();
        e.remove_policy(vec!["alice", "data1", "read"])
            .await
            .unwrap();
        e.add_policy(vec!["eve", "data3", "read"]).await.unwrap();
        e.add_policy(vec!["eve", "data3", "read"]).await.unwrap();
...

for remove_policies and add_policies as well (similarly for the other functions that have double checks)?

[GopherJ]

Hello @drholmie , yes u can open a new issue to better track the completion of tests.

Yes u can do that.

[drholmie]

Thanks for the go ahead @GopherJ !