Skip to content

Navigation Menu

Explore
By size
By industry
By use case
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

cartridge-gg / controller Public

Notifications You must be signed in to change notification settings
Fork 17
Star 52

Code
Issues 22
Pull requests 23
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmocking guardian #824

Closed

piniom wants to merge 12 commits into main from feature/guardian-unmock-1

+22,376 −19,636

Conversation 4 Commits 12 Checks 16 Files changed 16

Closed

Unmocking guardian #824

Show file tree

Hide file tree

Changes from 1 commit

Commits

Show all changes

Select commit Hold shift + click to select a range

changed contracts to enforce guardian signature

piniom Oct 16, 2024

added guardian tests (failing)

piniom Oct 16, 2024

allowed redundant guardian signature

piniom Oct 16, 2024

added correct session hashing to correctly sign in proxy

piniom Oct 16, 2024

added guardian checking in sessions

piniom Oct 16, 2024

adjusted tests to the new session guardian logic (1 fails)

piniom Oct 16, 2024

revert controller changes

piniom Oct 16, 2024

contract: added `is_session_registered` method

piniom Oct 16, 2024

`TransactionWaiter` fixed bug with not erroring when transaction reve…

piniom Oct 16, 2024

proxy: added guardian signature when estimating fee

piniom Oct 16, 2024

guardian tests pass

piniom Oct 16, 2024

remove `Debug` derive on `Controller`

piniom Oct 16, 2024

File filter

Filter by extension

Filter by extension .cairo (1) .json (2) All 2 file types selected

Viewed files

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

- - controller.latest.compiled_contract_class.json
  - controller.latest.contract_class.json
- - account.cairo

Previous commit

Next commit

allowed redundant guardian signature

Loading branch information

piniom committed Oct 16, 2024

commit 77725cba12da51318be8ec0893d4cbb70160ad7c

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 packages/account_sdk/artifacts/controller.latest.compiled_contract_class.json

Show comments

View file

Open in desktop

Large diffs are not rendered by default.

Oops, something went wrong.

Loading

Oops, something went wrong.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.