Unmocking guardian #824
Closed
Unmocking guardian #824
+22,376
−19,636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tarrencev
reviewed
Oct 4, 2024
| class_hash: Felt, | ||
| provider: P, | ||
| owner: Signer, | ||
| guardian: Option<Signer>, |
There was a problem hiding this comment.
im not sure if we want this here. since the sdk would never be it's own guardian. the guardian signer would come from the cartridge backend
piniom
force-pushed
the
feature/guardian-unmock-1
branch
from
b4f4815
to
44445de
Compare
tarrencev
reviewed
Oct 10, 2024
| @@ -454,10 +489,20 @@ mod CartridgeAccount { | |||
| fn assert_valid_span_signature( | |||
| self: @ContractState, hash: felt252, signer_signatures: Array<SignerSignature> | |||
| ) { | |||
| assert(signer_signatures.len() <= 2, 'invalid-signature-length'); | |||
| assert(signer_signatures.len() >= 1, 'empty-signatures'); | |||
There was a problem hiding this comment.
Suggested change
| assert(signer_signatures.len() >= 1, 'empty-signatures'); | |
| assert(signer_signatures.len() <= 1, 'empty-signatures'); |
tarrencev
reviewed
Oct 10, 2024
| 'invalid-guardian-sig' | ||
| ); | ||
| }, | ||
| Option::None => { assert(signer_signatures.len() == 1, 'unexpected-guardian-sig'); } |
There was a problem hiding this comment.
i think we can just pass here
piniom
force-pushed
the
feature/guardian-unmock-1
branch
from
44445de
to
262f972
Compare
piniom
force-pushed
the
feature/guardian-unmock-1
branch
from
262f972
to
5c60dc4
Compare
piniom
force-pushed
the
feature/guardian-unmock-1
branch
from
5fcafa0
to
2423b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.